Skip to content

Deprecate ExtraConfigmapsMounts parameter - #541

Open
kstrenkova wants to merge 1 commit into
openstack-k8s-operators:mainfrom
kstrenkova:deprecate-extra-configmaps-mounts-parameter
Open

Deprecate ExtraConfigmapsMounts parameter#541
kstrenkova wants to merge 1 commit into
openstack-k8s-operators:mainfrom
kstrenkova:deprecate-extra-configmaps-mounts-parameter

Conversation

@kstrenkova

@kstrenkova kstrenkova commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

The ExtraConfigmapsMounts parameter has been set to be deprecated since September 2025. The ExtraMounts parameter has been added to be used instead and every related code has been marked with a warning of deprecation.

This PR is removing all code related to the ExtraConfigmapsMounts parameter, from the parameter itself, deprecation warnings in webhooks, to mounting of the volumes. It should be the final step to moving to using ExtraMounts parameter only.

@openshift-ci
openshift-ci Bot requested review from adrianfusco and rebtoor October 5, 2026 10:49
@openshift-ci

openshift-ci Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kstrenkova

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Oct 5, 2026 •
edited
Loading

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: Central YAML (base), Organization UI (inherited)
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 63edfd57-759b-4fc8-842e-6705413ed4a1
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot added the approved label Oct 5, 2026
@centosinfra-prod-github-app

centosinfra-prod-github-app Bot commented Oct 5, 2026

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/810469913fe04cd99627ba2f649e12b7

✔️ test-operator-s2i-content-provider SUCCESS in 1h 12m 36s (non-voting)
⚠️ test-operator-kuttl-s2i SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider (non-voting)
⚠️ test-operator-s2i-test SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider (non-voting)
❌ openstack-k8s-operators-content-provider NODE_FAILURE Node(set) request 100-0000223449 failed in 0s
⚠️ test-operator-kuttl SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ podified-multinode-edpm-deployment-crc-test-operator SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@kstrenkova
Deprecate ExtraConfigmapsMounts parameter
0895f7a 
The ExtraConfigmapsMounts parameter has been set to be deprecated
since September 2025. The ExtraMounts parameter has been added to
be used instead and every related code has been marked with a
warning of deprecation.

This PR is removing all code related to the ExtraConfigmapsMounts
parameter, from the parameter itself, deprecation warnings in
webhooks, to mounting of the volumes. It should be the final step
to moving to using ExtraMounts parameter only.
@kstrenkova
kstrenkova force-pushed the deprecate-extra-configmaps-mounts-parameter branch from 629b952 to 0895f7a Compare October 8, 2026 10:40
@openshift-ci openshift-ci Bot added the approved label Oct 8, 2026
@centosinfra-prod-github-app

centosinfra-prod-github-app Bot commented Oct 9, 2026

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/47a4593b20d54d7d9ed4a91bdc8e7000

✔️ test-operator-s2i-content-provider SUCCESS in 16h 39m 02s (non-voting)
✔️ test-operator-kuttl-s2i SUCCESS in 34m 41s (non-voting)
❌ test-operator-s2i-test FAILURE in 2h 07m 40s (non-voting)
✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 05m 49s
✔️ test-operator-kuttl SUCCESS in 36m 37s
❌ podified-multinode-edpm-deployment-crc-test-operator FAILURE in 2h 21m 40s

@kstrenkova

kstrenkova commented Oct 9, 2026

Copy link
Copy Markdown
Contributor Author

recheck

@centosinfra-prod-github-app

centosinfra-prod-github-app Bot commented Oct 9, 2026

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/b8d6e7e9bfd64cc9b21f43dfe18a177c

✔️ test-operator-s2i-content-provider SUCCESS in 2h 52m 28s (non-voting)
✔️ test-operator-kuttl-s2i SUCCESS in 36m 13s (non-voting)
❌ test-operator-s2i-test FAILURE in 19m 22s (non-voting)
✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 58m 55s
❌ test-operator-kuttl FAILURE in 19m 54s
✔️ podified-multinode-edpm-deployment-crc-test-operator SUCCESS in 2h 31m 53s

@kstrenkova

kstrenkova commented Oct 9, 2026

Copy link
Copy Markdown
Contributor Author

recheck

@centosinfra-prod-github-app

centosinfra-prod-github-app Bot commented Oct 9, 2026

Copy link
Copy Markdown

Build succeeded (check pipeline).
https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/78e66a75bf2147beabcc12eeff5dadd0

✔️ test-operator-s2i-content-provider SUCCESS in 8h 17m 11s (non-voting)
✔️ test-operator-kuttl-s2i SUCCESS in 34m 35s (non-voting)
✔️ test-operator-s2i-test SUCCESS in 2h 23m 42s (non-voting)
✔️ openstack-k8s-operators-content-provider SUCCESS in 5h 10m 51s
✔️ test-operator-kuttl SUCCESS in 34m 56s
✔️ podified-multinode-edpm-deployment-crc-test-operator SUCCESS in 2h 42m 36s

@kstrenkova

kstrenkova commented Oct 12, 2026

Copy link
Copy Markdown
Contributor Author

/override ci/prow/precommit-check

The precommit-check will not pass due to the removal of a parameter. However, this is a conscious choice and the users have been warned for over a year that the parameter will be deprecated.

@openshift-ci

openshift-ci Bot commented Oct 12, 2026

Copy link
Copy Markdown
Contributor

@kstrenkova: Overrode contexts on behalf of kstrenkova: ci/prow/precommit-check

Details

In response to this:

/override ci/prow/precommit-check

The precommit-check will not pass due to the removal of a parameter. However, this is a conscious choice and the users have been warned for over a year that the parameter will be deprecated.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adrianfusco adrianfusco Awaiting requested review from adrianfusco
@rebtoor rebtoor Awaiting requested review from rebtoor

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

approved do-not-merge/hold

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@kstrenkova